Messages in this thread |  | | Date | Thu, 14 Nov 2013 10:20:36 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn |
| |
(2013/10/16 6:04), David Long wrote: > From: "David A. Long" <dave.long@linaro.org> > > Instead of depending on include/asm/kprobes.h to provide a dummy definition > for struct arch_specific_insn, do so in include/linux/kprobes.h.
Nak, why do we need ugly #ifdef again there? And also, please cc to the original maintainers.
Thank you,
> > Signed-off-by: David A. Long <dave.long@linaro.org> > --- > include/linux/kprobes.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h > index 925eaf2..4b5a74d 100644 > --- a/include/linux/kprobes.h > +++ b/include/linux/kprobes.h > @@ -52,9 +52,6 @@ > > #else /* CONFIG_KPROBES */ > typedef int kprobe_opcode_t; > -struct arch_specific_insn { > - int dummy; > -}; > #endif /* CONFIG_KPROBES */ > > struct kprobe; > @@ -110,7 +107,11 @@ struct kprobe { > kprobe_opcode_t opcode; > > /* copy of the original instruction */ > +#ifdef CONFIG_KPROBES > struct arch_specific_insn ainsn; > +#else > + int ainsn; > +#endif > > /* > * Indicates various status flags. >
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
|  |