[lkml]   [2013]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] gcc4: Disable __compiletime_object_size for GCC 4.6+
On 11/13/2013 10:39 AM, Kees Cook wrote:
> Hi Guenter,
> On Fri, Apr 12, 2013 at 07:49:08PM -0700, Guenter Roeck wrote:
>> __builtin_object_size is known to be broken on gcc 4.6+.
>> See for details.
>> This causes unnecssary build warnings and errors such as
>> In function 'copy_from_user', inlined from 'sb16_copy_from_user'
>> at sound/oss/sb_audio.c:878:22:
>> arch/x86/include/asm/uaccess_32.h:211:26: error: call to 'copy_from_user_overflow'
>> declared with attribute error: copy_from_user() buffer size is not provably correct
>> make[3]: [sound/oss/sb_audio.o] Error 1 (ignored)
>> Disable it where broken.
> Is there an alternative? This means that things like
> DEBUG_STRICT_USER_COPY_CHECKS are being rendered useless. I don't think
> this is _always_ broken, just under certain situations, right?

It would be one thing to block it for, say, gcc 4.6 and 4.7 only, but
without an upper cap I don't think this is at all okay.


 \ /
  Last update: 2013-11-13 22:41    [W:0.056 / U:59.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site