lkml.org 
[lkml]   [2013]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: nohz problem with idle time on old hardware
On Wed, 13 Nov 2013 17:07:18 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:


> Right. It's telling you if NOHZ is enabled. It's not telling you that
> NOHZ is active.

Yeah, which makes this code rather silly:

in rcu_prepare_for_idle():

/* Handle nohz enablement switches conservatively. */
tne = ACCESS_ONCE(tick_nohz_enabled);
if (tne != rdtp->tick_nohz_enabled_snap) {
if (rcu_cpu_has_callbacks(cpu, NULL))
invoke_rcu_core(); /* force nohz to see update. */
rdtp->tick_nohz_enabled_snap = tne;
return;
}

-- Steve


\
 
 \ /
  Last update: 2013-11-13 18:01    [W:0.068 / U:2.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site