Messages in this thread Patch in this message |  | | Date | Wed, 13 Nov 2013 15:36:12 +0100 | From | Oleg Nesterov <> | Subject | [PATCH 2/3] fork: no need to initialize child->exit_state |
| |
A zombie task obviously can't fork(), remove the unnecessary initialization of child->exit_state. It is zero anyway after dup_task_struct().
Note: copy_process() is huge and it has a lot of chaotic initializations, probably it makes sense to move them into the new helper called by dup_task_struct().
Signed-off-by: Oleg Nesterov <oleg@redhat.com> --- kernel/fork.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c index 8531609..2cb6024 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1405,13 +1405,11 @@ static struct task_struct *copy_process(unsigned long clone_flags, p->tgid = p->pid; } - p->pdeath_signal = 0; - p->exit_state = 0; - p->nr_dirtied = 0; p->nr_dirtied_pause = 128 >> (PAGE_SHIFT - 10); p->dirty_paused_when = 0; + p->pdeath_signal = 0; INIT_LIST_HEAD(&p->thread_group); p->task_works = NULL; -- 1.5.5.1
|  |