Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCHSET 00/13] tracing/uprobes: Add support for more fetch methods (v6) | Date | Tue, 12 Nov 2013 16:49:30 +0900 |
| |
Hi Oleg,
On Fri, 8 Nov 2013 18:00:17 +0100, Oleg Nesterov wrote: > On 11/07, Namhyung Kim wrote: >> >> On Wed, 6 Nov 2013 19:24:08 +0100, Oleg Nesterov wrote: >> > >> > Note that instruction_pointer_set() is not really nice in any case, >> > this can obviously confuse FETCH_MTD_reg("ip"). >> >> Yes. >> >> > >> > But lets ignore this. The solution is simple, we can pass/use this >> > info via current->utask. We can either add the new member, or add >> > a union. Or simply reuse xol_vaddr. Doesn't matter. >> >> Okay, I'll take a look. > > I guess we need the union in uprobe_task anyway... I'll send the patch > soon. > > Until we have the new members in uprobe_task, you can reuse utask->vaddr, > this is safe. > > IOW, you can use current->utask->vaddr instead of regs->ip (as we did > in the previous discussin) to pass the necessary info to ->fetch().
Thanks for the info! Namhyung
| |