lkml.org 
[lkml]   [2013]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] uprobes: Add uprobe_task->dup_work/dup_addr
> Yes, and it is always equal to regs->ip when pre_ssout() is called,
>
> > and do the necessary fixups after single stepping out of line.
>
> Exactly. So it is write-only (and meaningless) to the generic uprobe
> code. We can (and perhaps should) move it into autask->saved_vaddr,
> arch_uprobe_pre_xol() can initialize it.
>
> > The casual reading of this commit message, one can get an impression
> > that vaddr is never needed.
>
> See above. The changelog doesn't say we can simply remove it, it says
> "move it".


Okay, moving to arch_uprobe_task is fine. I probably got confused by
"First of all it is not really needed,"
>
> > Your change still retains it.
>
>
> OK. How about dup_xol_work/dup_xol_vaddr ?
>

Yes fine with me.

--
Thanks and Regards
Srikar Dronamraju



\
 
 \ /
  Last update: 2013-11-12 19:41    [W:0.124 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site