Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH] perf tools: Prevent condition that all sort keys are elided | Date | Tue, 12 Nov 2013 16:14:04 +0900 |
| |
Hi Ingo,
On Mon, 11 Nov 2013 12:20:13 +0100, Ingo Molnar wrote: > * Namhyung Kim <namhyung@kernel.org> wrote: >> + /* >> + * It makes no sense to elide all of sort entries. >> + * Just revert them to show up again. >> + */ >> + list_for_each_entry(se, &hist_entry__sort_list, list) >> + if (!se->elide) >> + return; > > (Nit: please use curly braces around multi-line statements.)
Ah, okay.
> >> + >> + list_for_each_entry(se, &hist_entry__sort_list, list) >> + se->elide = false; > > Looks good otherwise - this is the first step in the sort/key behavior > improvements that we talked about a few days ago, right?
Right. And I'd like to wait bit more to hear other's opinion on this.
> > Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks, Namhyung
| |