Messages in this thread Patch in this message | | | Date | Tue, 12 Nov 2013 08:56:07 -0800 | From | Kees Cook <> | Subject | [PATCH] x86, kaslr: use char array to gain sizeof sanity |
| |
The build_str needs to be char [] not char * for the sizeof() to report the string length.
Reported-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: Kees Cook <keescook@chromium.org> --- arch/x86/boot/compressed/aslr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/aslr.c b/arch/x86/boot/compressed/aslr.c index 8746487fa916..9777ed15fbb9 100644 --- a/arch/x86/boot/compressed/aslr.c +++ b/arch/x86/boot/compressed/aslr.c @@ -13,7 +13,7 @@ #include <linux/version.h> /* Simplified build-specific string for starting entropy. */ -static const char *build_str = UTS_RELEASE " (" LINUX_COMPILE_BY "@" +static const char build_str[] = UTS_RELEASE " (" LINUX_COMPILE_BY "@" LINUX_COMPILE_HOST ") (" LINUX_COMPILER ") " UTS_VERSION; #define I8254_PORT_CONTROL 0x43 -- 1.7.9.5
-- Kees Cook Chrome OS Security
| |