lkml.org 
[lkml]   [2013]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 05/15] usb: phy: msm: Fix checkpatch.pl warnings
    Date
    From: "Ivan T. Ivanov" <iivanov@mm-sol.com>

    This fixes following:

    WARNING: quoted string split across lines
    WARNING: Prefer seq_puts to seq_printf

    Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
    ---
    drivers/usb/phy/phy-msm-usb.c | 39 ++++++++++++++-------------------------
    1 file changed, 14 insertions(+), 25 deletions(-)

    diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
    index 0bd9614..8f148a6 100644
    --- a/drivers/usb/phy/phy-msm-usb.c
    +++ b/drivers/usb/phy/phy-msm-usb.c
    @@ -67,8 +67,7 @@ static int msm_hsusb_init_vddcx(struct msm_otg *motg, int init)
    USB_PHY_VDD_DIG_VOL_MIN,
    USB_PHY_VDD_DIG_VOL_MAX);
    if (ret) {
    - dev_err(motg->phy.dev, "unable to set the voltage "
    - "for hsusb vddcx\n");
    + dev_err(motg->phy.dev, "Cannot set vddcx voltage\n");
    return ret;
    }

    @@ -79,8 +78,7 @@ static int msm_hsusb_init_vddcx(struct msm_otg *motg, int init)
    ret = regulator_set_voltage(motg->vddcx, 0,
    USB_PHY_VDD_DIG_VOL_MAX);
    if (ret)
    - dev_err(motg->phy.dev, "unable to set the voltage "
    - "for hsusb vddcx\n");
    + dev_err(motg->phy.dev, "Cannot set vddcx voltage\n");
    ret = regulator_disable(motg->vddcx);
    if (ret)
    dev_err(motg->phy.dev, "unable to disable hsusb vddcx\n");
    @@ -97,8 +95,7 @@ static int msm_hsusb_ldo_init(struct msm_otg *motg, int init)
    rc = regulator_set_voltage(motg->v3p3, USB_PHY_3P3_VOL_MIN,
    USB_PHY_3P3_VOL_MAX);
    if (rc) {
    - dev_err(motg->phy.dev, "unable to set voltage level "
    - "for hsusb 3p3\n");
    + dev_err(motg->phy.dev, "Cannot set v3p3 voltage\n");
    goto exit;
    }
    rc = regulator_enable(motg->v3p3);
    @@ -109,8 +106,7 @@ static int msm_hsusb_ldo_init(struct msm_otg *motg, int init)
    rc = regulator_set_voltage(motg->v1p8, USB_PHY_1P8_VOL_MIN,
    USB_PHY_1P8_VOL_MAX);
    if (rc) {
    - dev_err(motg->phy.dev, "unable to set voltage level "
    - "for hsusb 1p8\n");
    + dev_err(motg->phy.dev, "Cannot set v1p8 voltage\n");
    goto disable_3p3;
    }
    rc = regulator_enable(motg->v1p8);
    @@ -144,8 +140,7 @@ static int msm_hsusb_config_vddcx(struct msm_otg *motg, int high)

    ret = regulator_set_voltage(motg->vddcx, min_vol, max_vol);
    if (ret) {
    - pr_err("%s: unable to set the voltage for regulator "
    - "HSUSB_VDDCX\n", __func__);
    + dev_err(motg->phy.dev, "Cannot set vddcx voltage\n");
    return ret;
    }

    @@ -163,15 +158,13 @@ static int msm_hsusb_ldo_set_mode(struct msm_otg *motg, int on)
    ret = regulator_set_optimum_mode(motg->v1p8,
    USB_PHY_1P8_HPM_LOAD);
    if (ret < 0) {
    - pr_err("%s: Unable to set HPM of the regulator "
    - "HSUSB_1p8\n", __func__);
    + pr_err("Could not set HPM for v1p8\n");
    return ret;
    }
    ret = regulator_set_optimum_mode(motg->v3p3,
    USB_PHY_3P3_HPM_LOAD);
    if (ret < 0) {
    - pr_err("%s: Unable to set HPM of the regulator "
    - "HSUSB_3p3\n", __func__);
    + pr_err("Could not set HPM for v3p3\n");
    regulator_set_optimum_mode(motg->v1p8,
    USB_PHY_1P8_LPM_LOAD);
    return ret;
    @@ -180,13 +173,11 @@ static int msm_hsusb_ldo_set_mode(struct msm_otg *motg, int on)
    ret = regulator_set_optimum_mode(motg->v1p8,
    USB_PHY_1P8_LPM_LOAD);
    if (ret < 0)
    - pr_err("%s: Unable to set LPM of the regulator "
    - "HSUSB_1p8\n", __func__);
    + pr_err("Could not set LPM for v1p8\n");
    ret = regulator_set_optimum_mode(motg->v3p3,
    USB_PHY_3P3_LPM_LOAD);
    if (ret < 0)
    - pr_err("%s: Unable to set LPM of the regulator "
    - "HSUSB_3p3\n", __func__);
    + pr_err("Could not set LPM for v3p3\n");
    }

    pr_debug("reg (%s)\n", on ? "HPM" : "LPM");
    @@ -547,8 +538,7 @@ static int msm_otg_resume(struct msm_otg *motg)
    * PHY. USB state can not be restored. Re-insertion
    * of USB cable is the only way to get USB working.
    */
    - dev_err(phy->dev, "Unable to resume USB."
    - "Re-plugin the cable\n");
    + dev_err(phy->dev, "Unable to resume USB. Re-plugin the cable\n");
    msm_otg_reset(phy);
    }

    @@ -1242,13 +1232,13 @@ static int msm_otg_mode_show(struct seq_file *s, void *unused)

    switch (otg->phy->state) {
    case OTG_STATE_A_HOST:
    - seq_printf(s, "host\n");
    + seq_puts(s, "host\n");
    break;
    case OTG_STATE_B_PERIPHERAL:
    - seq_printf(s, "peripheral\n");
    + seq_puts(s, "peripheral\n");
    break;
    default:
    - seq_printf(s, "none\n");
    + seq_puts(s, "none\n");
    break;
    }

    @@ -1530,8 +1520,7 @@ static int __init msm_otg_probe(struct platform_device *pdev)
    motg->pdata->otg_control == OTG_USER_CONTROL) {
    ret = msm_otg_debugfs_init(motg);
    if (ret)
    - dev_dbg(&pdev->dev, "mode debugfs file is"
    - "not available\n");
    + dev_dbg(&pdev->dev, "Can not create mode change file\n");
    }

    pm_runtime_set_active(&pdev->dev);
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2013-11-12 16:21    [W:4.045 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site