Messages in this thread | | | Date | Tue, 5 Nov 2013 10:43:54 +0100 | From | David Sterba <> | Subject | Re: [PATCH] BTRFS: fixed coding style issues |
| |
On Tue, Nov 05, 2013 at 09:02:01AM +0200, Aldo Iljazi wrote: > Line 4989: Inserted a space after the comma. > Lines 7986 and 8274: Inserted a space before the open parenthesis.
Hm, I don't know why my message from yesterday did not make it to the list, but I'm objecting against flow of such changes that are not always actual changes (replacing spaces by tabs). We don't really need them at this point of development phase of btrfs.
The style issues should be fixed when a patch is being merged, doing it afterwards increases patch history and makes digging in history unnecessarily tedious.
There are lots of opportunities to do actual code cleanup, whitespaces are just noise.
david
| |