lkml.org 
[lkml]   [2013]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] perf trace: Fix segfault on perf trace -i perf.data
On Tue, Nov 12, 2013 at 09:15:08AM -0300, Arnaldo Carvalho de Melo wrote:
> Second part, just rewrote the changelog a bit:
>
> commit 4e8a6e566fc611b9cbec2978a52266f29cb65785
> Author: Namhyung Kim <namhyung.kim@lge.com>
> Date: Tue Nov 12 15:25:00 2013 +0900
>
> perf trace: Fix segfault on perf trace -i perf.data
>
> When replaying a previous record session, it'll get a segfault since it
> doesn't initialize raw_syscalls enter/exit tracepoint's evsel->priv for
> caching the format fields.
>
> So fix it by properly initializing sys_enter/exit evsels that comes from
> reading the perf.data file header.

Looks good to me!

Thanks for doing this, Arnaldo. I'll try to avoid this kind of thing
again in the future.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-11-12 14:21    [W:0.098 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site