lkml.org 
[lkml]   [2013]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] x86/boot changes for v3.13

* Borislav Petkov <bp@alien8.de> wrote:

> On Mon, Nov 11, 2013 at 01:37:48PM -0800, Yinghai Lu wrote:
> > How do you know CPU0 and CPU1 are in same package?
>
> Why is that relevant?

So I suspect what Yinghai tried to say if CPU0 and CPU1 are not on the
same node we do the printout incorrectly.

Arguably this was a pre-existing condition, but would be nice to fix it
now that this code has emerged out of steady bitrot! :-)

How difficult would it be in your opinion? I think the best way to go
about it would be to include CPU#0 in the list - I don't think anyone will
be confused by the fact that it has already booted. That way the 'gap' for
CPU#0 would be eliminated. Or something like that.

Btw., while staring at that code once more I noticed the following small
nit, there's a pre-existing weird way of writing the -1 literal:

if (current_node > (-1))

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-11-12 12:41    [W:0.083 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site