lkml.org 
[lkml]   [2013]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tools lib traceevent: Add direct access to dynamic arrays
On Mon, Nov 11, 2013 at 04:08:10PM -0500, Steven Rostedt wrote:
>
> Jiri Olsa was writing a plugin for the cfg80211_tx_mlme_mgmt trace
> event, and was not able to get the implemented function working.
> The event's print fmt looks like:
>
> "netdev:%s(%d), ftype:0x%.2x", REC->name, REC->ifindex,
> __le16_to_cpup((__le16 *)__get_dynamic_array(frame))
>
> As there's no helper function for __le16_to_cpup(), Jiri was creating one
> with a plugin. But unfortunately, it would not work even though he set
> up the plugin correctly.
>
> The problem is that the function parameters do not handle the helper
> function "__get_dynamic_array()", and that passes in a NULL pointer.
>
> Adding PRINT_DYNAMIC_ARRAY direct support to eval_num_arg() allows the
> use of __get_dynamic_array() in function parameters.
>
> Reported-by: Jiri Olsa <jolsa@redhat.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

cool, thanks

Tested-by: Jiri Olsa <jolsa@redhat.com>


jirka


\
 
 \ /
  Last update: 2013-11-12 11:01    [W:0.350 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site