Messages in this thread Patch in this message | | | Date | Tue, 12 Nov 2013 11:22:44 +0800 | Subject | Re: kernel BUG at kernel/kallsyms.c:222! | From | Ming Lei <> |
| |
On Tue, Nov 12, 2013 at 3:32 AM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Mon, Nov 11, 2013 at 05:15:29PM +0000, Jonathan Austin wrote: >> I've tested the patch below and it solves the ARM side of things - so >> gives you an option other than a complete revert. Happy to put this in to >> RMK's patch system if you'd prefer not to have to revert and he's happy >> with the patch. > > I think this is the right solution because it then means that this symbol > has the same meaning whether on MMU or !MMU - and getting rid of these > kinds of gratuitous variances are the only way that !MMU is going to > become less fragile.
The patch only fixes problem on arm, and other !MMU&&!ARM archs should be affected too.
Also there is no CONFIG_PAGE_OFFSET defined for some ARCHs, such as 64bit ARCHs.
Currently, I suggest to filter only on ARM as attachment patch if we plan to merge Jonathan's patch, otherwise a more complicated approach has to be figured out to do the filter(such as, define a readonly symbol in kernel to store PAGE_OFFSET, and let scripts/kallsyms use it for filtering).
Thanks, -- Ming Lei diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index 32b10f5..2dca94a 100644 --- a/scripts/link-vmlinux.sh +++ b/scripts/link-vmlinux.sh @@ -82,7 +82,9 @@ kallsyms() kallsymopt="${kallsymopt} --all-symbols" fi - kallsymopt="${kallsymopt} --page-offset=$CONFIG_PAGE_OFFSET" + if [ -n "${CONFIG_ARM}" ] + kallsymopt="${kallsymopt} --page-offset=$CONFIG_PAGE_OFFSET" + fi local aflags="${KBUILD_AFLAGS} ${KBUILD_AFLAGS_KERNEL} \ ${NOSTDINC_FLAGS} ${LINUXINCLUDE} ${KBUILD_CPPFLAGS}" | |