Messages in this thread | | | Date | Mon, 11 Nov 2013 16:12:01 -0800 | From | David Cohen <> | Subject | Re: [PATCHv5.1 4/5] check quirk to pad epout buf size when not aligned to maxpacketsize |
| |
Hi Michal,
On 11/11/2013 03:58 PM, Michal Nazarewicz wrote: > Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires > to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs > to pad epout buffer to match above condition if quirk is found. > > Signed-off-by: Michal Nazarewicz <mina86@mina86.com> > --- > drivers/usb/gadget/f_fs.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > On Tue, Nov 12 2013, David Cohen wrote: >> One curiosity here. This patch prints the following warning: >> >> In file included from (...)/drivers/usb/gadget/g_ffs.c:55:0: >> (...)/drivers/usb/gadget/f_fs.c: In function 'ffs_epfile_io.isra.18': >> (...)/drivers/usb/gadget/f_fs.c:837:15: warning: 'data_len' may be used >> uninitialized in this function [-Wmaybe-uninitialized] > > With the below code, this should no longer be a problem. > > Also fixes issues pointed out by Alan.
You need to update req->length otherwise it's going to crash DWC3. I'd rather to keep your previous version.
Br, David
| |