Messages in this thread |  | | Date | Mon, 11 Nov 2013 15:11:31 -0800 | From | David Cohen <> | Subject | Re: [PATCH 1/2] usb: gadget: f_fs: remove loop from I/O function |
| |
Hi Michal,
On 11/10/2013 08:50 AM, Michal Nazarewicz wrote: > From: Michal Nazarewicz <mina86@mina86.com> > > When endpoint changes (due to it being disabled or alt setting changed), > mimic the action as if the change happened after the request has been > queued, instead of retrying with the new endpoint. > > Signed-off-by: Michal Nazarewicz <mina86@mina86.com> > --- > drivers/usb/gadget/f_fs.c | 94 +++++++++++++++++++++-------------------------- > 1 file changed, 41 insertions(+), 53 deletions(-) > > diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c > index 44cf775..f875f26 100644 > --- a/drivers/usb/gadget/f_fs.c > +++ b/drivers/usb/gadget/f_fs.c > @@ -754,74 +754,61 @@ static ssize_t ffs_epfile_io(struct file *file, > { > struct ffs_epfile *epfile = file->private_data; > struct ffs_ep *ep; > - char *data = NULL; > ssize_t ret; > + char *data;
You can't non-initialize data, otherwise we'll end up with this correct warning: drivers/usb/gadget/f_fs.c:866:7: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized]
If you agree, you can send v5.1 to my 5th patch set (or let me handle it).
Br, David
|  |