Messages in this thread | | | Date | Mon, 11 Nov 2013 14:15:00 -0800 | From | Dave Hansen <> | Subject | Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage |
| |
On 11/06/2013 05:45 AM, Zhi Yong Wu wrote: > Introduce a /proc interface hot-mem-high-thresh and > to cap the memory which is consumed by hot_inode_item > and hot_range_item, and they will be in the unit of > 1M bytes.
You don't seem to have any documentation for this, btw... :(
> + .procname = "hot-mem-high-thresh",
*Always* put units on these. I know you mention it in a code comment, but please also include it in the proc filename too.
In general, why do you have to control the number of these statically? Shouldn't you just define a shrinker and let memory pressure determine how many of these we allow to exist?
| |