Messages in this thread | | | Date | Mon, 11 Nov 2013 13:44:20 -0700 | From | David Ahern <> | Subject | Re: [PATCH 2/2] perf record: mmap output file - v4 |
| |
On 11/11/13, 1:41 PM, Ingo Molnar wrote: > > * David Ahern <dsahern@gmail.com> wrote: > >> On 11/11/13, 7:58 AM, Arnaldo Carvalho de Melo wrote: >>> >>>> Looks very clean now! >>> >>>> Acked-by: Ingo Molnar <mingo@kernel.org> >>> >>> Applied the prep patch, but waiting for v5 as stated by David when >>> answering Jiri's concerns. >> >> I'll re-send - giving some time for comments on the use of >> setjmp/longjmp to bounce out of memcpy and error exit when filesystem >> runs out of space. > > Maybe that could be an add-on patch instead?
That's what Arnaldo and I were thinking. > > All the rest would already be an improvement, right?
Yes. The longjmp handles the out-of-space failure condition trying to write the data to a file. With mmap writes you get a SIGBUS when the filesystem is full and you need to bail out of the memcpy.
David
| |