Messages in this thread | | | Date | Mon, 11 Nov 2013 15:44:38 +0800 | Subject | Re: [PATCH 1/2] firmware: Introduce request_firmware_direct() | From | Ming Lei <> |
| |
Hi Takashi,
On Tue, Nov 5, 2013 at 7:57 PM, Takashi Iwai <tiwai@suse.de> wrote: > When CONFIG_FW_LOADER_USER_HELPER is set, request_firmware() falls > back to the usermode helper for loading via udev when the direct > loading fails. But the recent udev takes way too long timeout (60 > seconds) for non-existing firmware. This is unacceptable for the > drivers like microcode loader where they load firmwares optionally, > i.e. it's no error even if no requested file exists. > > This patch provides a new helper function, request_firmware_direct(). > It behaves as same as request_firmware() except for that it doesn't > fall back to usermode helper but returns an error immediately if the > f/w can't be loaded directly in kernel. > > Without CONFIG_FW_LOADER_USER_HELPER=y, request_firmware_direct() is > just an alias of request_firmware(), due to obvious reason. > > Tested-by: Prarit Bhargava <prarit@redhat.com> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
The patch is fine, except it should be against -next, so you can feel free to add my Acked-by in your next submission.
Thanks, -- Ming Lei
| |