Messages in this thread | | | Date | Mon, 11 Nov 2013 08:54:04 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCH 0/3] omapdss: venc: Add support for bypass and acbias. |
| |
* Dr. H. Nikolaus Schaller <hns@goldelico.com> [131111 06:30]: > Am 11.11.2013 um 15:13 schrieb Tomi Valkeinen: > > On 2013-11-11 15:57, Dr. H. Nikolaus Schaller wrote: > > > > The display.c file is not strictly DSS stuff, but DSS related "glue" for > > the SoC. For example, the muxing of the DSI pads is also done on the > > CONTROL module, and it's also in display.c. > > > > The file is getting a bit large, so I'm not against splitting it. But I > > don't think there's point to add omap3-tvout.c file, which most likely > > will ever contain only that one function. > > Yes that is very likely true. > > The problem is that there is no other official API to modify the DEFCONF1 > register. Therefore we introduced this (propsal). > > Our first idea was a readDEFCONF1() and writeDEFCONF1() and use the > constants (bit patterns) you suggested below.
I posted something about accessing the ctrl module regs to the first patch in the series. It's best to set it up as a separate driver for now and then maybe handle it with pinctrl-single,bits when DSS is device tree enabled.
Regards,
Tony
| |