Messages in this thread | | | Date | Mon, 11 Nov 2013 17:30:42 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v3 0/2] ARC: Add perf support for ARC700 cores |
| |
On Mon, Nov 11, 2013 at 05:27:55PM +0100, Peter Zijlstra wrote: > On Thu, Nov 07, 2013 at 02:55:10PM +0100, Mischa Jonker wrote: > > Hi all, > > > > Please find v3 of my attempt to add support for perf for ARC700 PMU's. If > > possible, it would be nice to get some feedback on the implementation from > > non-ARC/Synopsys people familiar with the perf subsystem in Linux. > > Anything in particular you wanted feedback on? It looks like a fairly > straight fwd thingy.
Ah, so its one of those that cannot sample; you might want to fail when we try and create a sampling event.
Also, you could consider running an (hr)timer to periodically update the events so that you don't miss a hardware counter wrap around -- if that is a distinct possibility.
| |