lkml.org 
[lkml]   [2013]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] efi earlyprintk fix
On Sat, 09 Nov, at 11:44:29AM, Dave Young wrote:
> Hi, Matt
>
> Confirmed, your patch work ok for the pr_cont issue.

Excellent, thanks for testing.

> Actually I mixed two problems in my report, one is there's always one blank line
> at the bottom of screen, the other is the pr_cont issue. For the second problem
> change >= to > looks better. For the previous problem still need to move the
> hunk below to the beginning point of early_efi_write function. It just works for me
> but I'm not sure why this is not necessary for other machines.
>
> + if (efi_y + font->height > si->lfb_height) {
> + u32 i;
> +
> + efi_y -= font->height;
> + early_efi_scroll_up();
> +
> + for (i = 0; i < font->height; i++)
> + early_efi_clear_scanline(efi_y + i);
> + }

Dave, unfortunately you're going to need to debug this further because
it doesn't make any sense that your patch is needed, unless there's a
bug in the existing code.

You may also want to rule out that your boot_delay patches are not
inserting delays after printing pr_fmt().

--
Matt Fleming, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2013-11-11 17:21    [W:0.064 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site