Messages in this thread | | | Date | Mon, 11 Nov 2013 11:59:08 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf tool: Round mmap pages to power 2 |
| |
Em Mon, Nov 11, 2013 at 12:27:54PM +0100, Ingo Molnar escreveu: > * David Ahern <dsahern@gmail.com> wrote: > > > Currently perf requires the -m / --mmap_pages option to be a power of 2. > > To be more user friendly perf should automatically round this up to the > > next power of 2. > > > > Currently: > > $ perf record -m 3 -a -- sleep 1 > > --mmap_pages/-m value must be a power of two.sleep: Terminated > > > > With patch: > > $ perf record -m 3 -a -- sleep 1 > > rounding mmap pages size to 16384 (4 pages) > > Please add 'bytes'.
Ok, waiting for v2 with this and Adrian's concerns addressed.
- Arnaldo
| |