Messages in this thread | | | Date | Mon, 11 Nov 2013 15:22:53 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/3] panic: setup panic_timeout early |
| |
* Felipe Contreras <felipe.contreras@gmail.com> wrote:
> On Mon, Nov 11, 2013 at 7:44 AM, Ingo Molnar <mingo@kernel.org> wrote: > > > > * Felipe Contreras <felipe.contreras@gmail.com> wrote: > > > >> Otherwise we might not reboot when the user needs it the most (early > >> on). > >> > >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> > >> --- > >> kernel/panic.c | 14 +++++++++++++- > >> 1 file changed, 13 insertions(+), 1 deletion(-) > >> > >> diff --git a/kernel/panic.c b/kernel/panic.c > >> index b6c482c..46e37ff 100644 > >> --- a/kernel/panic.c > >> +++ b/kernel/panic.c > >> @@ -468,9 +468,21 @@ EXPORT_SYMBOL(__stack_chk_fail); > >> > >> #endif > >> > >> -core_param(panic, panic_timeout, int, 0644); > >> core_param(pause_on_oops, pause_on_oops, int, 0644); > >> > >> +static int __init set_panic_timeout(char *str) > >> +{ > >> + int timeout; > >> + > >> + if (!get_option(&str, &timeout)) > >> + return -EINVAL; > >> + > >> + panic_timeout = timeout; > >> + return 0; > >> +} > >> + > >> +early_param("panic_timeout", set_panic_timeout); > >> + > > > > For simple integer parameters simple_strtol() is better and (a tiny bit) > > faster. > > simple_strtol() is deprecated in favor of kstrtol().
Yes, true - my main point is that get_option() isn't the right choice here, you need to use a single-integer parsing function.
Thanks,
Ingo
| |