Messages in this thread | | | Subject | Re: [PATCHv2] net: wireless: iwlwifi: remove minor dead code | From | Johannes Berg <> | Date | Mon, 11 Nov 2013 14:42:38 +0100 |
| |
On Mon, 2013-11-11 at 14:41 +0100, Johannes Berg wrote: > > @@ -1150,7 +1149,14 @@ static irqreturn_t iwl_pcie_isr(int irq, void *data) > > * or due to sporadic interrupts thrown from our NIC. */ > > if (!inta) { > > IWL_DEBUG_ISR(trans, "Ignore interrupt, inta == 0\n"); > > - goto none; > > + /* re-enable interrupts here since we don't have anything to > > + * service. only Re-enable if disabled by irq and no > > + * schedules tasklet. > > + */ > > + if (test_bit(STATUS_INT_ENABLED, &trans_pcie->status) && > > + !trans_pcie->inta) > > + iwl_enable_interrupts(trans); > > + return IRQ_NONE; > > I don't really think duplicating this is really an improvement?
Err, sorry, not paying attention.
johannes
| |