Messages in this thread | | | Date | Mon, 11 Nov 2013 13:49:53 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/3] panic: improve panic_timeout calculation |
| |
* Felipe Contreras <felipe.contreras@gmail.com> wrote:
> On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar <mingo@kernel.org> wrote: > > > > * Felipe Contreras <felipe.contreras@gmail.com> wrote: > > > >> We want to calculate the blinks per second, and instead of making it 5 > >> (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks > >> per second. > > > > Please use the customary changelog style we use in the kernel: > > > > " Current code does (A), this has a problem when (B). > > We can improve this doing (C), because (D)." > > A is explained, B is empty, C is explained, D is because it makes sense.
NAKed-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
| |