Messages in this thread | | | Date | Mon, 11 Nov 2013 13:06:55 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH V3 06/11] perf record: Add an option to force per-cpu mmaps |
| |
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Nov 05, 2013 at 02:31:52PM -0300, Arnaldo Carvalho de Melo wrote: > > PeterZ, > > > > Can I have your Acked-by for this one? I guess now the goal is > > achieved, no? > > So this option allows -t/-p/-u to create one buffer per cpu and attach > all the various thread/process/user tasks' their counters to that one > buffer? > > As opposed to the current state where each such counter would have its > own buffer. > > If this is what the patch does, then yes, although I would prefer a > slightly clearer Changelog. > > Acked-by: Peter Zijlstra <peterz@infradead.org>
Is there any reason why we wouldn't want to make this the default behavior?
That way we could also lose the somewhat suboptimal 'force' naming: there's nothing forced really, we simply switch to another ring-buffer setup ...
Thanks,
Ingo
| |