lkml.org 
[lkml]   [2013]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 06/11] perf record: Add an option to force per-cpu mmaps

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, Nov 05, 2013 at 02:31:52PM -0300, Arnaldo Carvalho de Melo wrote:
> > PeterZ,
> >
> > Can I have your Acked-by for this one? I guess now the goal is
> > achieved, no?
>
> So this option allows -t/-p/-u to create one buffer per cpu and attach
> all the various thread/process/user tasks' their counters to that one
> buffer?
>
> As opposed to the current state where each such counter would have its
> own buffer.
>
> If this is what the patch does, then yes, although I would prefer a
> slightly clearer Changelog.
>
> Acked-by: Peter Zijlstra <peterz@infradead.org>

Is there any reason why we wouldn't want to make this the default
behavior?

That way we could also lose the somewhat suboptimal 'force' naming:
there's nothing forced really, we simply switch to another ring-buffer
setup ...

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-11-11 13:21    [W:0.089 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site