Messages in this thread | | | Date | Mon, 11 Nov 2013 12:53:07 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 4/4] perf record: mmap output file - v3 |
| |
* David Ahern <dsahern@gmail.com> wrote:
> >>+do_mmap: > >>+ offset = rec->session->header.data_offset + rec->bytes_written; > >>+ if (offset < (ssize_t) rec->mmap_out_size) { > >>+ rec->mmap_offset = offset; > >>+ offset = 0; > >>+ } else > >>+ rec->mmap_offset = 0; > > > >(Nit: unbalanced curly braces.) > > I believe checkpatch.pl complains, but will add.
Hm, if that is so then please report that to the checkpatch folks, the warning is bogus and causes worse code to be written.
Thanks,
Ingo
| |