lkml.org 
[lkml]   [2013]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] perf record: mmap output file - v3

* David Ahern <dsahern@gmail.com> wrote:

> >>+do_mmap:
> >>+ offset = rec->session->header.data_offset + rec->bytes_written;
> >>+ if (offset < (ssize_t) rec->mmap_out_size) {
> >>+ rec->mmap_offset = offset;
> >>+ offset = 0;
> >>+ } else
> >>+ rec->mmap_offset = 0;
> >
> >(Nit: unbalanced curly braces.)
>
> I believe checkpatch.pl complains, but will add.

Hm, if that is so then please report that to the checkpatch folks, the
warning is bogus and causes worse code to be written.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-11-11 13:21    [W:0.041 / U:1.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site