lkml.org 
[lkml]   [2013]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [OPW kernel] Re: [PATCH v10] Staging: zram: Fix memory leak by refcount mismatch
From
On Sun, Nov 10, 2013 at 9:15 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Nov 01, 2013 at 07:36:09PM +0530, Rashika Kheria wrote:
>> As suggested by Minchan Kim and Jerome Marchand "The code in reset_store
>> get the block device (bdget_disk()) but it does not put it (bdput()) when
>> it's done using it. The usage count is therefore incremented but never
>> decremented."
>>
>> This patch also puts bdput() for all error cases.
>>
>> Acked-by: Minchan Kim <minchan@kernel.org>
>> Acked-by: Jerome Marchand <jmarchan@redhat.com>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>> ---
>>
>> This revision fixes the following issue of the previous revision-
>> Incorrect Subject Line
>
> I'm a bit confused now, I see three different zram patches from you,
> with different subjects, are they all now just in one patch, this one?
>
> Can you just send me the outstanding zram patches that you have gotten
> acks from that you want applied, as I'm lost here.
>
> thanks,
>
> greg "easily confused" k-h
>

Hi Greg,

You have already applied the rest two patches for this driver. This is
the only patch which is left.

But I think you might have problem applying this because there have
been changes in previous patches later i.e you applied v8 of this
series, while, maintainers later suggested to change more and hence v9
was also introduced.

Therefore, v9's patch 1 and v10 patch is correct to be applied in the tree.

Thanks,
--
Rashika Kheria
B.Tech CSE
IIIT Hyderabad


\
 
 \ /
  Last update: 2013-11-10 17:21    [W:0.817 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site