[lkml]   [2013]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC/PATCHSET 00/14] perf report: Add support to accumulate hist periods (v2)

* Namhyung Kim <> wrote:

> >> > 2)
> >> >
> >> > Is it possible to configure the default 'report -g' style, so that
> >> > people who'd like to use it all the time don't have to type '-g
> >> > cumulative' all the time?
> >>
> >> Hmm.. maybe I can add support for the '' config option.
> >
> > If we display your new 'total' field by default then it's not as
> > pressing to me :)
> Do you mean -g cumulative without 'self' column?

So, if by default we display both 'self' and 'total' and sort by
'total', then I'm personally a happy camper: while it's a change of
the default perf report output, it's also a step forward.

But some people might complain about it once this hits v3.13 (or
v3.14) and might want to hide individual columns and have different
sorting preferences.

So out of defensive caution you might want to provide toggles for
such things, maybe even generalize it a bit to allow arbitrary
hiding/display of individual colums in perf report.

That would probably also make it easier to do minimal tweaks to the
upstream reporting defaults.

> > Btw., if anyone is interested in improving the GTK front-end, it
> > would be _really_ nice if it had a 'start profiling' button like
> > sysprof has today, with a 'samples' field showing the current
> > number of samples. (We could even improve upon sysprof by adding
> > 'stop' functionality as well ;-)
> Wow, I'm impressed that the sysprof doesn't have one. :)

At least I haven't found it: I tried pressing 'start' once more but
that doesn't do it, it just keeps collecting data.

Still many developers love sysprof, so I think there would be quite
some plus in providing a gtk perf top version with the controls
Pekka and me listed.



 \ /
  Last update: 2013-11-01 10:41    [W:0.103 / U:8.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site