lkml.org 
[lkml]   [2013]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int()
    From
    From: Cong Wang <xiyou.wangcong@gmail.com>
    Date: Thu, 31 Oct 2013 21:19:16 -0700

    > 2013年10月30日 下午9:26于 "David Miller" <davem@davemloft.net>写道:
    >>
    >> We have to provide a softint compatible environment for this callback
    >> to run in else everything is completely broken.
    >>
    >> All these drivers can safely assume softirq safe locking is
    >> sufficient, you're suggesting we need to take this hardirq safety and
    >> I'm really not willing to allow things to go that far. A lot of
    >> effort has been expended precisely to avoid that kind of overhead and
    >> cost.
    >
    > Alright, I am thinking to move netpoll_poll_dev() to a delayed work.

    What if the printk is outputting a message that will help us discover
    that work queues are deadlocked?

    You can't delay the message, because every layer of indirection you
    add increases the possibility that the message it never seen. You
    have to do it synchronously.


    \
     
     \ /
      Last update: 2013-11-01 23:21    [W:3.476 / U:0.628 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site