Messages in this thread |  | | Date | Fri, 1 Nov 2013 11:50:45 -0700 | From | Mark Brown <> | Subject | Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator. |
| |
On Fri, Nov 01, 2013 at 03:04:52PM +0800, Xiubo Li wrote: > On VF610 series there are no regulators used, and now whether the > CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio > patch series, the board cannot be probe successfully. > And this patch will solve this issue.
I don't understand what this is for at all, you're just saying there is a problem you're trying to solve but you don't explain anything about what the problem is or how your changes address it.
> +#ifndef CONFIG_SND_SOC_FSL_SGTL5000_VF610 > static int ldo_regulator_register(struct snd_soc_codec *codec,
This is definitely broken, it won't work with multi-platform kernels, and I don't understand what this is supposed to do - what is the reason for making this change? [unhandled content-type:application/pgp-signature] |  |