[lkml]   [2013]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: perf version not set when building out of tree

* David Ahern <> wrote:

> When building out of tree:
> make perf-tar-src-pkg

What's the canonical way to build a perf tarball? I didn't find any
makefile target for that.

> tar -xf perf-<ver>.tar -C /tmp
> cd /tmp/perf<ver>
> make -C tools/perf
> you get the warning message:
> make[1]: *** No rule to make target `kernelversion'. Stop.
> which comes from tools/perf/util/PERF-VERSION-GEN,
> if test -z "$TAG"
> then
> TAG=$(MAKEFLAGS= make -sC ../.. kernelversion)
> fi
> There is no top level Makefile. perf is actually built, but has no
> version info:
> $ tools/perf/perf --version
> perf version
> I thought someone had proposed a way to fix that.

I think we should pack the PERF-VERSION-FILE with the tarball and
use that. This needs roughly 3 changes:

- make PERF-VERSION-FILE part of the tarball
- make sure it's not zapped on 'make clean'
- don't try to regenerate it if there's no git repository to get a version from



 \ /
  Last update: 2013-11-01 08:21    [W:0.109 / U:59.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site