Messages in this thread |  | | Date | Fri, 1 Nov 2013 08:02:19 +0100 | From | Ingo Molnar <> | Subject | Re: perf version not set when building out of tree |
| |
* David Ahern <dsahern@gmail.com> wrote:
> When building out of tree: > > make perf-tar-src-pkg
What's the canonical way to build a perf tarball? I didn't find any makefile target for that.
> tar -xf perf-<ver>.tar -C /tmp > cd /tmp/perf<ver> > make -C tools/perf > > you get the warning message: > make[1]: *** No rule to make target `kernelversion'. Stop. > > which comes from tools/perf/util/PERF-VERSION-GEN, > > if test -z "$TAG" > then > TAG=$(MAKEFLAGS= make -sC ../.. kernelversion) > fi > > There is no top level Makefile. perf is actually built, but has no > version info: > > $ tools/perf/perf --version > perf version > > I thought someone had proposed a way to fix that.
I think we should pack the PERF-VERSION-FILE with the tarball and use that. This needs roughly 3 changes:
- make PERF-VERSION-FILE part of the tarball - make sure it's not zapped on 'make clean' - don't try to regenerate it if there's no git repository to get a version from
Thanks,
Ingo
|  |