Messages in this thread |  | | Date | Fri, 01 Nov 2013 10:34:23 -0600 | From | Jens Axboe <> | Subject | Re: stec skd block driver needs updating for immutable biovec |
| |
On 11/01/2013 10:28 AM, Mike Snitzer wrote: > On Fri, Nov 01 2013 at 12:02pm -0400, > Jens Axboe <axboe@kernel.dk> wrote: > >> On 11/01/2013 09:50 AM, Christoph Hellwig wrote: >>> On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote: >>>> All the bi_sector ones are low hanging fruit, but the conversion for >>>> skd_preop_sg_list_bio()'s bio_vec code is more involved. >>>> >>>> Kent, any chance you could crank through it? >>>> >>>> If not I can come back to trying to fix this later.. but I'm working >>>> through a test merge of linux-dm.git's 'for-next' with linux-block.git's >>>> 'for-next'. >>> >>> The right thing for 3.13 is to rip out the bio base code path, and >>> for 3.14 to convert it to blk-mq. >> >> It is. I will kill it. > > I just cranked through it.. hope this helps (think I got everything but > may have missed something):
You lost out, I committed it 20 min ago :-0
http://git.kernel.dk/?p=linux-block.git;a=commit;h=1d36f7a5fb577afaaead6c5e2fc8e01e0c95235d
Looks like you missed some of the skd_device removal, while I neglected killing bio/start_time in the skd_request_context.
-- Jens Axboe
|  |