Messages in this thread |  | | Date | Fri, 1 Nov 2013 16:20:00 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 3/4] perf tools: Add call-graph option support into .perfconfig |
| |
On Tue, Oct 29, 2013 at 11:18:21AM +0100, Jiri Olsa wrote: > On Mon, Oct 28, 2013 at 05:10:54PM +0900, Namhyung Kim wrote: > > On Sat, 26 Oct 2013 16:25:35 +0200, Jiri Olsa wrote: > > > Adding call-graph option support into .perfconfig file, > > > so it's now possible use call-graph option like: > > > > > > [top] > > > call-graph = fp > > > > > > [record] > > > call-graph = dwarf,8192 > > > > > > Above options ONLY setup the unwind method. To enable > > > perf record/top to actually use it the command line > > > option -g/-G must be specified. > > > > > > The --call-graph option overloads .perfconfig setup. > > > > > > Assuming above configuration: > > > > > > $ perf record -g ls > > > - enables dwarf unwind with user stack size dump 8192 bytes > > > > > > $ perf top -G > > > - enables frame pointer unwind > > > > > > $ perf record --call-graph=fp ls > > > - enables frame pointer unwind > > > > > > $ perf top --call-graph=dwarf,4096 ls > > > - enables dwarf unwind with user stack size dump 4096 bytes > > > > > [SNIP] > > > --- a/tools/perf/builtin-record.c > > > +++ b/tools/perf/builtin-record.c > > > @@ -750,6 +750,8 @@ int record_parse_callchain_opt(const struct option *opt, > > > struct perf_record_opts *opts = opt->value; > > > int ret; > > > > > > + opts->call_graph_enabled = !unset; > > > + > > > > Why not just using symbol_conf.use_callchain? > > > > right, this way we'd be in sync with top
hum, on the other hand using symbol_conf.use_callchain within utils/evsel.c adds symbol object dependency to python code which I'm not sure is something we want ;-)
I'll keep it as it is in v2
jirka
|  |