lkml.org 
[lkml]   [2013]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH trace-cmd 1/5] trace-cmd/listen: Remove use of sighandler_t
On Mon, 28 Oct 2013 10:45:41 -0500
Seth Forshee <seth.forshee@canonical.com> wrote:

>
> >From 20ec8510d0ca2ac789b1ca9cf7b0a6dc2d02f14c Mon Sep 17 00:00:00 2001
> From: Seth Forshee <seth.forshee@canonical.com>
> Date: Mon, 28 Oct 2013 08:15:59 -0500
> Subject: [PATCH] Makefile: Ensure _GNU_SOURCE really is always defined
>
> When CLFAGS is set with a command argument a normal variable
> assignment is not sufficient to ensure that _GNU_SOURCE will be
> defined. Since this really is critical for building, use an
> override directive when adding it to CFLAGS to ensure that it
> really does get defined in all cases.

Can you send this as a separate patch please. New patches should not
be replies. You can reply to a patch with a patch, but please change
the subject when you do so.

Thanks,

-- Steve

>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 1d613c4..a2ba385 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -223,7 +223,7 @@ CFLAGS ?= -g -Wall
> LDFLAGS ?=
>
> # Required CFLAGS
> -CFLAGS += -D_GNU_SOURCE
> +override CFLAGS += -D_GNU_SOURCE
>
> ifndef NO_PTRACE
> ifneq ($(call try-cc,$(SOURCE_PTRACE),),y)



\
 
 \ /
  Last update: 2013-11-01 15:01    [W:0.080 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site