lkml.org 
[lkml]   [2013]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] perf tools: Remove cast of non-varadic function to varadic
Date
Hi Arnaldo and Michael,

On Thu, 31 Oct 2013 18:09:50 -0200, Arnaldo Carvalho de Melo wrote:
> Em Thu, Oct 31, 2013 at 12:50:25PM -0700, Michael Hudson-Doyle escreveu:
>> 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) introduced a cast of
>> percent_color_snprintf to a function pointer type with varargs. Change
>> percent_color_snprintf to be varadic and remove the cast.
>>
>> The symptom of this was all percentages being reported as 0.00% in perf
>> report --stdio output on armhf.
>
> git bisect + visual inspection, right? Anyway, good catch, interesting
> it caused problems on just one arch, or have you tested this in other
> arches?
>
> Namhyung?

Yes, it'll affect the way of passing parameter on some arch's - I only
tested it on x86_64. So,

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-11-01 13:41    [W:0.059 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site