Messages in this thread |  | | Subject | Re: [PATCH net-next V3 2/2] virtio-net: coalesce rx frags when possible during rx | From | Eric Dumazet <> | Date | Fri, 01 Nov 2013 02:47:22 -0700 |
| |
On Fri, 2013-11-01 at 14:07 +0800, Jason Wang wrote: > Commit 2613af0ed18a11d5c566a81f9a6510b73180660a (virtio_net: migrate mergeable > rx buffers to page frag allocators) try to increase the payload/truesize for > MTU-sized traffic. But this will introduce the extra overhead for GSO packets > received because of the frag list. This commit tries to reduce this issue by > coalesce the possible rx frags when possible during rx. Test result shows the > about 15% improvement on full size GSO packet receiving (and even better than > before commit 2613af0ed18a11d5c566a81f9a6510b73180660a). > > Before this commit: > ./netperf -H 192.168.100.4 > MIGRATED TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 192.168.100.4 > () port 0 AF_INET : demo > Recv Send Send > Socket Socket Message Elapsed > Size Size Size Time Throughput > bytes bytes bytes secs. 10^6bits/sec > > 87380 16384 16384 10.00 20303.87 > > After this commit: > ./netperf -H 192.168.100.4 > MIGRATED TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to 192.168.100.4 > () port 0 AF_INET : demo > Recv Send Send > Socket Socket Message Elapsed > Size Size Size Time Throughput > bytes bytes bytes secs. 10^6bits/sec > > 87380 16384 16384 10.00 23841.26 > > Cc: Rusty Russell <rusty@rustcorp.com.au> > Cc: Michael S. Tsirkin <mst@redhat.com> > Cc: Michael Dalton <mwdalton@google.com> > Cc: Eric Dumazet <edumazet@google.com> > Acked-by: Michael S. Tsirkin <mst@redhat.com> > Acked-by: Eric Dumazet <edumazet@google.com> > Signed-off-by: Jason Wang <jasowang@redhat.com> > --- > Changes from V2: > - call put_page() instead of depending on skb_coalesce_rx_frag() > ---
Yes, very nice improvement, thanks again !
Acked-by: Eric Dumazet <edumazet@google.com>
|  |