Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 1/8] perf callchain: Convert children list to rbtree | Date | Thu, 10 Oct 2013 10:06:08 +0900 |
| |
Hi Frederic,
On Tue, 8 Oct 2013 21:22:45 +0200, Frederic Weisbecker wrote: > On Tue, Oct 08, 2013 at 11:03:16AM +0900, Namhyung Kim wrote: >> On Wed, 2 Oct 2013 12:18:28 +0200, Frederic Weisbecker wrote: >> > Have you tested this patchset when collapsing is not used? >> > There are fair chances that this patchset does not only improve collapsing >> > but also callchain insertion in general. So it's probably a win in any case. But >> > still it would be nice to make sure that it's the case because we are getting >> > rid of collapsing anyway. >> > >> > The test that could tell us about that is to run "perf report -s sym" and compare the >> > time it takes to complete before and after this patch, because "-s sym" shouldn't >> > involve collapses. >> > >> > Sorting by anything that is not comm should do the trick in fact. >> >> Yes, I have similar result when collapsing is not used. Actually when I >> ran "perf report -s sym", the performance improves higher since it'd >> insert more callchains in a hist entry. > > Great! I'll have a closer look and review on the callchain patches then. Please > resend these along the comm batch.
I'll do it later today or tomorrow.
Thanks, Namhyung
| |