Messages in this thread | | | Date | Wed, 9 Oct 2013 17:28:33 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH v2 tip/core/rcu 07/13] ipv6/ip6_tunnel: Apply rcu_access_pointer() to avoid sparse false positive |
| |
On Wed, Oct 09, 2013 at 05:12:40PM -0700, Eric Dumazet wrote: > On Wed, 2013-10-09 at 16:40 -0700, Josh Triplett wrote: > > > that. Constructs like list_del_rcu are much clearer, and not > > open-coded. Open-coding synchronization code is almost always a Bad > > Idea. > > OK, so you think there is synchronization code. > > I will shut up then, no need to waste time.
As you said earlier, we should at least get rid of the memory barrier as long as we are changing the code.
Josh, what would you suggest as the best way to avoid the memory barrier, keep sparse happy, and not be too ugly?
Thanx, Paul
| |