lkml.org 
[lkml]   [2013]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rtc: rtc-puv3: use dev_dbg() instead of pr_debug()
On 10/09/2013 03:20 PM, Joe Perches wrote:
> On Wed, 2013-10-09 at 14:49 +0900, Sangjung Woo wrote:
>> Because dev_*() are used along with pr_debug() function in this code,
>> the debug message is not tidy. This patch converts from pr_debug() to
>> dev_dbg() since dev_*() are encouraged to use in device driver code.
> []
>> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
> []
>> @@ -57,7 +57,7 @@ static void puv3_rtc_setaie(int to)
>> {
>> unsigned int tmp;
>>
>> - pr_debug("%s: aie=%d\n", __func__, to);
>> + dev_dbg(dev, "%s: aie=%d\n", __func__, to);
> Does this compile?
>
>
Oops! I did not add my local modification into the patch.
The function parameters should be modified as below.

-static void puv3_rtc_setaie(int to)
+static void puv3_rtc_setaie(struct device *dev, int to)


I will send the new one.
Thank you for your good review.

Cheers, Sangjung



\
 
 \ /
  Last update: 2013-10-09 09:01    [W:1.245 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site