Messages in this thread | | | Subject | Re: [PATCH] rtc: pl030: Use devm_kzalloc() instead of kmalloc() | From | Joe Perches <> | Date | Tue, 08 Oct 2013 21:07:29 -0700 |
| |
On Wed, 2013-10-09 at 13:00 +0900, Sangjung Woo wrote: > In order to be free automatically and make the cleanup paths more > simple, use devm_kzalloc() instead of kzalloc(). [] > diff --git a/drivers/rtc/rtc-pl030.c b/drivers/rtc/rtc-pl030.c [] > @@ -106,7 +106,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id) > if (ret) > goto err_req; > > - rtc = kmalloc(sizeof(*rtc), GFP_KERNEL); > + rtc = devm_kzalloc(&dev->dev, sizeof(*rtc), GFP_KERNEL);
You're not deleting a memset and you're converting a kmalloc.
Why do you need the zalloc version?
| |