lkml.org 
[lkml]   [2013]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: mm: Export 'pageflag_names' array
From
Hi

On Tue, Oct 8, 2013 at 5:40 AM, Dave Anderson <anderson@redhat.com> wrote:
>
>
> ----- Original Message -----
>> Hi Anatol,
>>
>> On Mon, Oct 07, 2013 at 10:53:32AM -0700, Anatol Pomozov wrote:
>> > Hi Wu
>> >
>> > I have a request wrt your old commit 718a38211.
>> >
>> > I think it makes sense to export array pageflag_names so kernel dump
>> > debug tools (like 'crash') can use it as well. Currently the tool
>> > hard-codes flag names but it is suboptimal as flags are different for
>> > different configs.
>> >
>> > What do you think? (I can send a patch if you are ok).
>>
>> I wonder if the KPF_* defined in
>>
>> include/uapi/linux/kernel-page-flags.h
>>
>> fit your needs. These are kernel page flags exported to the user space
>> and will be maintained stable and immune to kconfig changes. You can
>> find use examples of them in
>>
>> fs/proc/page.c
>> tools/vm/page-types.c
>>
>> Thanks,
>> Fengguang
>>
>
> Nothing is required for the crash utility. The pageflag_names array (as well
> as the pageflags enumerator) are readily available in the kernel debuginfo
> data.

D'oh. You are right Dave. Everyone, please ignore my original question
I mislooked this variable in symbols map (or maybe looked at an old
kernel map).

Dave, do you think 'crash' should use pageflag_names to output flag names?


\
 
 \ /
  Last update: 2013-10-08 20:41    [W:0.055 / U:2.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site