Messages in this thread | | | Date | Tue, 8 Oct 2013 16:45:20 +0100 | From | Al Viro <> | Subject | Re: [PATCH 28/29] tracehook_signal_handler: Remove sig, info, ka and regs |
| |
On Tue, Oct 08, 2013 at 01:36:18PM +0200, Richard Weinberger wrote: > These parameters are nowhere used, so we can remove them.
I'm not sure it's a good idea... OTOH, it probably has no business in tracehook.h anymore - it's only called from signal_delivered(), so if we decide to insert some ptrace-related work, we can bloody well do it there these days. It used to be called all over the place in arch/*, which made a centralized definition (and getting all potentially relevant data to it) a lot more important. So I'd probably suggest killing that function off completely - signal_delivered() acts as such centralized location these days.
| |