lkml.org 
[lkml]   [2013]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only
On Mon, Oct 07, 2013 at 12:34:33PM -0700, Josh Triplett wrote:

> I've seen far more examples of the 80-column limit making code less
> readable rather than more. It's only really helpful when it forces code
> restructuring, *not* when it just forces an arbitrary line break.

So teach that piece of crap to complain about fucked-in-head line breaks like
ret_val =
leaf_shift_left(tb,
tb->
lnum
[0],
tb->
lbytes
-
1);
in addition to obscenely long lines (and yes, it is a real-world example).

The one and only point of such tools is to help locating the crappy code.
And that's the only sane criterion for evaluating new "stylistic rules" -
does that particular heuristic catch enough shitty places or not?

_Anything_ can be obfuscated to the point where warnings are not produced
anymore...


\
 
 \ /
  Last update: 2013-10-07 23:41    [W:0.139 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site