lkml.org 
[lkml]   [2013]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:perf/core] perf/x86: Clean up cap_user_time* setting
On Mon, Oct 07, 2013 at 10:22:06AM -0700, H. Peter Anvin wrote:
> CONFIG_X86_TSC is a baseline control option; we shouldn't key
> functionality off of it. It's fine to say notsc -> no tracing, but
> making it a compile-time key makes me a bit uphappy. We cut off 386,
> but cutting of 486 at this point makes me nervous.

The thing that annoys me about notsc is that it disables usage even if
its present.

I've no problem with 486 which simply doesn't have TSC and thus
cpu_has_tsc will be false and other stuff will happen -- and I don't
think my proposition would actually change anything there.

What is completely insane is people using notsc on say a haswell chip
and expecting something sane to happen.

So I'm not proposing we remove !cap_has_tsc support; all I'm proposing
is we remove the notsc knob that avoids using the TSC on perfectly good
hardware.


\
 
 \ /
  Last update: 2013-10-07 20:01    [W:0.285 / U:1.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site