lkml.org 
[lkml]   [2013]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 26/63] sched: Check current->mm before allocating NUMA faults
    Date
    task_numa_placement checks current->mm but after buffers for faults
    have already been uselessly allocated. Move the check earlier.

    [peterz@infradead.org: Identified the problem]
    Signed-off-by: Mel Gorman <mgorman@suse.de>
    ---
    kernel/sched/fair.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    index dce3545..9eb384b 100644
    --- a/kernel/sched/fair.c
    +++ b/kernel/sched/fair.c
    @@ -930,8 +930,6 @@ static void task_numa_placement(struct task_struct *p)
    int seq, nid, max_nid = -1;
    unsigned long max_faults = 0;

    - if (!p->mm) /* for example, ksmd faulting in a user's mm */
    - return;
    seq = ACCESS_ONCE(p->mm->numa_scan_seq);
    if (p->numa_scan_seq == seq)
    return;
    @@ -998,6 +996,10 @@ void task_numa_fault(int last_nid, int node, int pages, bool migrated)
    if (!numabalancing_enabled)
    return;

    + /* for example, ksmd faulting in a user's mm */
    + if (!p->mm)
    + return;
    +
    /* For now, do not attempt to detect private/shared accesses */
    priv = 1;

    --
    1.8.4


    \
     
     \ /
      Last update: 2013-10-07 13:21    [W:4.074 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site