lkml.org 
[lkml]   [2013]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] kernel/irq/proc.c: set MAX_NAMELEN 11 instead of 10 which express the maximize size of "%d" or "%u".
From
On Sat, Oct 5, 2013 at 5:46 PM, Chen Gang <gang.chen@asianux.com> wrote:
> On 10/05/2013 11:41 PM, Joe Perches wrote:
>> On Sat, 2013-10-05 at 23:19 +0800, Chen Gang wrote:
>>> Theoretically, the maximize size of "%d" or "%u" is 11 (10 + '\0'), so
>>> need set MAX_NAMELEN 11 instead of 10.
>>
>> %d can be negative.
>>
>>
>>
>>
>
> Oh, really, it is incorrect. Al Viro succeeds once. :-(
>
> And I should send patch v2 for it.

irq is in both register_irq_proc() and unregister_irq_proc() an unsigned int.
Therefore %d makes not really sense. Both should use %u.
IMHO sprintf() should also get replaced by snprintf() but that's a
matter of taste.

--
Thanks,
//richard


\
 
 \ /
  Last update: 2013-10-05 18:21    [W:0.051 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site