lkml.org 
[lkml]   [2013]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] sh: clkfwk: Select sh-/common- clkfwk alternatively
Hi Laurent,

> While I agree with this patch, I believe the use of the HAVE_MACH_CLKDEV
> configuration option to select whether to compile core.o in is a bit of an
> abuse. <snip>
Well, yes, indeed. It does not mean having include/mach/clkdev.h,
but means somewhat such like !COMMON_CLK.
# I think there is similar usage in arch/mips, though they define but not use.
# ... is an execution.

> However, as all ARCH_SHMOBILE platforms should be converted to the common
> clock framework, this is only temporary and could be revisited later, so I'm
> fine with keeping the patch as-is.
Sure.

Thank you for your review.
/yoshii


\
 
 \ /
  Last update: 2013-10-04 07:41    [W:0.049 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site