Messages in this thread Patch in this message | | | Date | Fri, 4 Oct 2013 10:35:08 -0700 | From | tip-bot for Peter Zijlstra <> | Subject | [tip:sched/core] sched/wait: Collapse __wait_event_interruptible_lock_irq() |
| |
Commit-ID: 8fbd88fa1717601ef91ced49a32f24786b167065 Gitweb: http://git.kernel.org/tip/8fbd88fa1717601ef91ced49a32f24786b167065 Author: Peter Zijlstra <peterz@infradead.org> AuthorDate: Wed, 2 Oct 2013 11:22:28 +0200 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Fri, 4 Oct 2013 10:16:19 +0200
sched/wait: Collapse __wait_event_interruptible_lock_irq()
Reduce macro complexity by using the new ___wait_event() helper. No change in behaviour, identical generated code.
Reviewed-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20131002092528.686006009@infradead.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- include/linux/wait.h | 26 ++++++-------------------- 1 file changed, 6 insertions(+), 20 deletions(-)
diff --git a/include/linux/wait.h b/include/linux/wait.h index d64918e..a577a85 100644 --- a/include/linux/wait.h +++ b/include/linux/wait.h @@ -689,26 +689,12 @@ do { \ } while (0) -#define __wait_event_interruptible_lock_irq(wq, condition, \ - lock, ret, cmd) \ -do { \ - DEFINE_WAIT(__wait); \ - \ - for (;;) { \ - prepare_to_wait(&wq, &__wait, TASK_INTERRUPTIBLE); \ - if (condition) \ - break; \ - if (signal_pending(current)) { \ - ret = -ERESTARTSYS; \ - break; \ - } \ - spin_unlock_irq(&lock); \ - cmd; \ - schedule(); \ - spin_lock_irq(&lock); \ - } \ - finish_wait(&wq, &__wait); \ -} while (0) +#define __wait_event_interruptible_lock_irq(wq, condition, lock, ret, cmd) \ + ___wait_event(wq, condition, TASK_INTERRUPTIBLE, 0, ret, \ + spin_unlock_irq(&lock); \ + cmd; \ + schedule(); \ + spin_lock_irq(&lock)) /** * wait_event_interruptible_lock_irq_cmd - sleep until a condition gets true.
| |